Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not initialize unnecessarily #426

Closed
wants to merge 1 commit into from

Conversation

marco-carvalho
Copy link
Contributor

No description provided.

@github-actions github-actions bot added cpu An issue with ARMeilleure, the JIT, or Hypervisor gpu Affects GPU emulation graphics-backend:opengl Affects the OpenGL Graphics backend graphics-backend:vulkan Affects the Vulkan Graphics backend gui Affects the Avalonia UI or translations. horizon Affects the Horizon OS HLE components. ldn Affects the LDN functionality labels Dec 22, 2024
Copy link
Member

@GreemDev GreemDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add warning suppressions in the places with them.
A lot of them don't need to be fixed, since them never changing their value is mostly due to behavior that doesn't exist.

For example the _accumulatedSuspendedTickValue field in Ryujinx.HLE/HOS/Services/Am/AppletAE/AllSystemAppletProxiesService/SystemAppletProxy/ISelfController.cs; this value is used (I think) for calculating how long the guest application has been suspended for when the user hits the home button to return to QLaunch (Switch Home Screen). We don't support QLaunch and likely never will, thus this value will likely always stay at 0.
We could inline usages to remove traces of something we don't support, but I'd rather leave it as is so if someone with a desire to see QLaunch working, they can add it in and take advantage of the fact that we already partially have the code made in a way that makes it easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cpu An issue with ARMeilleure, the JIT, or Hypervisor gpu Affects GPU emulation graphics-backend:opengl Affects the OpenGL Graphics backend graphics-backend:vulkan Affects the Vulkan Graphics backend gui Affects the Avalonia UI or translations. horizon Affects the Horizon OS HLE components. ldn Affects the LDN functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants