Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation Project v2 #471

Merged
merged 59 commits into from
Dec 31, 2024
Merged

Validation Project v2 #471

merged 59 commits into from
Dec 31, 2024
+325 −239

Conversation

GreemDev
Copy link
Member

Original PR had issues in the CI when building.

Refactor of the Validation System for more ease of use in the future.
The project now builds a standalone executable and executes it before the main project is built or published.
Since it is now a standalone executable we are also able to use .NET Core features as we are no longer locked to netstandard.

The project currently includes 1 task, LocalesValidationTask, that will check if the locales.json file has any of the following issues:

  • The json is invalid.
  • The json has locales with missing languages.
  • The json has locales with langauges that are just duplicates of the en_US field.

If the project is built or published locally it will also fix any missing languages or duplicate fields.

LotP1 added 30 commits December 24, 2024 23:28
@LotP1
update gitignore
4275a77
@LotP1
please don't fail
f538cee
@LotP1
copying is not necessary anymore
732a1af
@LotP1
lets give this another shot
748e93b 
moved from netstandard to netframework
@LotP1
this won't work
b19ee23
@LotP1
v3
695f9e2
@LotP1
NO-BREAK SPACE is now escaped
097836b
@LotP1
here we go
d83d80d
@LotP1
test stuff
dac137f
@LotP1
please
1bac6ab
@LotP1
v4
8c0a82b
@LotP1
use outdir
b00d80c
@LotP1
Revert "use outdir"
7b8c877 
This reverts commit b00d80c.
@LotP1
confirm that it actually builds
9ca0926
@LotP1
lets see what's actually going on
21f23f0
@LotP1
build target fix
c91d9d8
@LotP1
manually run dotnet restore
eb46909
@LotP1
force restore
4add482
@LotP1
try simplified csproj and force runtime identifier
35b23bc
@LotP1
test RuntimeIdentifiers
9320dec
@LotP1
use RuntimeIdentifier instead
2fe1904
@LotP1
correct form of --runtime
e3638d1
@LotP1
forgot to remove true
0cde245
@LotP1
check target dir
a317184
@LotP1
v4 first test, will fail due to new validation step
bad1f72
@LotP1
missing quote, will still fail
1dbcaf1
@LotP1
run with dotnet dll runner
80377c1
@LotP1
slash instead of backslash
8cb6767
@LotP1
Merge remote-tracking branch 'upstream/master' into validation-v2
d9f2b81
@LotP1
simplify
f976c3c
LotP1 and others added 16 commits December 26, 2024 23:32
@LotP1
fix matching windows runner
fdece62
@LotP1
only log runtime if a runtime is set
2a38f1b
@LotP1
fix spelling and names
aabb786
@GreemDev
Rename program.cs to Program.cs
aa806b1
@LotP1
force line endings to use LF
e2e8502
@LotP1
Merge remote-tracking branch 'upstream/master' into validation-v2
4f206d0
@LotP1
Merge branch 'master' into validation-v2
9f22fc4
@LotP1
fix duplicates
4b84c5d
@LotP1
Merge remote-tracking branch 'upstream/master' into validation-v2
55f6b95
@LotP1
remove dupelicates
43f6e4a
@LotP1
validate that line endings are LF on build
4e56b14 
if running on git it will now fail if the file contains CRLF line endings and tell the user to run a local build to fix it.
@LotP1
slight refactor
8efefea 
isGitRunner is now a variable passed to all tasks.
Validation project can now accept more arguments, only the first argument is used at the moment.
Execute is no longer static, and you can now pass extra data to the task constructor if needed.
@GreemDev
Merge branch 'master' into validation-v2
af44726
@LotP1
remove unnecessary references
e9b614d
@LotP1
Merge remote-tracking branch 'upstream/master' into validation-v2
0ca3aa4
@LotP1
validate json
33800c1
@github-actions github-actions bot added gui Affects the Avalonia UI or translations. infra Updates to dependencies labels Dec 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 30, 2024 •
edited
Loading

Download the artifacts for this pull request:

Only for Developers

@GreemDev GreemDev merged commit d0a344d into Ryubing:master Dec 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
gui Affects the Avalonia UI or translations. infra Updates to dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GreemDev @LotP1