Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for clip animation and animation related performance. #102

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Fixes for clip animation and animation related performance. #102

merged 1 commit into from
Dec 26, 2023

Conversation

ILOVEPIE
Copy link
Member

  • Fixed a oversight with regard to detecting animations that resulted in animations being detected in most cases when there were none; hurting performance.
  • Fixed subtitle event to just store the lineGlobalTransitionTargetOverrides instead of cloning them on fetch. This fixes clip animation via the transition tag.

@ILOVEPIE ILOVEPIE added the bug Something isn't working label Dec 26, 2023
@ILOVEPIE ILOVEPIE added this to the First Release milestone Dec 26, 2023
@ghost
Copy link

ghost commented Dec 26, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@ILOVEPIE ILOVEPIE merged commit 88fca13 into master Dec 26, 2023
3 checks passed
@ILOVEPIE ILOVEPIE deleted the animationFixup branch April 15, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
First Release
Development

Successfully merging this pull request may close these issues.
1 participant
@ILOVEPIE