#139 updated codeQL version to v2 and #3482 Fix user searches for var… #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iants where the N is accidentally ommitted from NM_
|
@Bharath-kandula It works well when searcing for uppercase, but doesn't work for "m_000546.5(TP53):c.1129A>C" for example. Also good to see that the basics of CodeQL is working again. |
…riants where the N is accidentally ommitted from NM_
TheMadBug
reviewed
Jul 31, 2023
genes/hgvs/hgvs_matcher.py
Outdated
| @@ -516,6 +516,8 @@ def clean_hgvs(self, hgvs_string) -> Tuple[str, List[str]]: | |||
| cleaned_hgvs = clean_string(hgvs_string) # remove non-printable characters | |||
| cleaned_hgvs = cleaned_hgvs.replace(" ", "") # No whitespace in HGVS | |||
| cleaned_hgvs = cleaned_hgvs.replace("::", ":") # Fix double colon | |||
| if cleaned_hgvs.startswith("M_") or cleaned_hgvs.startswith("m_"): | |||
There was a problem hiding this comment.
Really minor coding style preference:
Could you change this to
if cleaned_hgvs[0:2].upper() == "M_"
to avoid making a check for M_ and m_. Just saves us repeating ourselves a little bit.
…riants where the N is accidentally ommitted from NM_
TheMadBug
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iants where the N is accidentally ommitted from NM_