Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3485 handled search error for MedGen and providing external Link. #855

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

Bharath-kandula
Copy link
Contributor

No description provided.

@TheMadBug
Copy link
Member

As a correction to the original task, I noticed I said the URL for external links should appear like:
https://www.ncbi.nlm.nih.gov/medgen/?term=CN072330

But no reason we have to invoke MedGen's search, our external link for MedGen should be
https://www.ncbi.nlm.nih.gov/medgen/CN072330

Appologies for that, but should be a quick fix.
It would also be nice to have a comment explaining what the INVALID_INPUT constant does.
FYI PyCharm seems to be best at picking up comments in the form of triple double quote blocks e.g.

CleanShot 2023-08-04 at 10 45 16

CleanShot 2023-08-04 at 10 45 52

@TheMadBug TheMadBug merged commit a7d304a into master Aug 4, 2023
2 checks passed
@TheMadBug TheMadBug deleted the #3485_stop_MedGen_termm_trigger_hgvs branch August 4, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants