Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3481_updated codeQL to use conda env and updated env folder structure. #858

Closed
wants to merge 2 commits into from

Conversation

Bharath-kandula
Copy link
Contributor

No description provided.

@TheMadBug
Copy link
Member

@Bharath-kandula
If we look at the checks that were run as part of this issue:

First of all it's great that it let's us know if there are any new CodeQL issues - exactly what I wanted there.

But we also see that in Initialize CodeQL, it's actually running "Setup Python dependencies" and in that it actually successfully installs all the entries from requirements.txt via pip - thus making the "set up Conda" step redundant. Also since "set up Conda" step occurs after the "Perform CodeQL Analysis" step anyway, I doubt it's adding any value - other than proving that the conda environment.yml is valid.

That said, I couldn't actually find anything about conda in codeql-analysis.yml - is it maybe automatically doing conda because it found environment.yml or more likely am I just looking at codeql-analysis.yml in the wrong branch? If if it is in a yml somewhere I suggest we comment it out for now to save 5 minutes of verification time, but something we can put back in if needed.

@TheMadBug
Copy link
Member

This PR was effectively done by another PR

@TheMadBug TheMadBug closed this Aug 11, 2023
@TheMadBug TheMadBug deleted the 3481_github_actions branch November 2, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants