Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for IoN Neuro DB project #525

Merged
merged 9 commits into from
Dec 12, 2024
Merged

Add configuration for IoN Neuro DB project #525

merged 9 commits into from
Dec 12, 2024

Conversation

stefpiatek
Copy link
Contributor

Creating default configuration for IoN Neuro DB project.

We override sequentually so the first file to be read is the

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (9dbb114) to head (b478741).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          76       76           
  Lines        3386     3386           
=======================================
  Hits         2959     2959           
  Misses        427      427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefpiatek stefpiatek requested a review from p-j-smith November 25, 2024 09:29
Copy link
Contributor

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Does #508 need to be addressed before exporting data to the XNAT?

@stefpiatek
Copy link
Contributor Author

looks good! Does #508 need to be addressed before exporting data to the XNAT?

Yeah I think practially we won't actually export any data as part of this tranche of work, but setting up the configuration so we can test out the anonymisation within UCLH network. I guess I could temporarily just set both exports to none, but also there's no authentication set up to allow export so can't accidentaly do that

@stefpiatek stefpiatek enabled auto-merge (squash) December 12, 2024 09:17
@stefpiatek stefpiatek merged commit cf96120 into main Dec 12, 2024
11 checks passed
@stefpiatek stefpiatek deleted the ion_neuro_db branch December 12, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants