-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for DESPIAD project #572
base: main
Are you sure you want to change the base?
Conversation
this is because resources sharing the same StudyInstanceUID in Orthanc Raw will be combined into a single resource in Orthanc Anon. Previously, we would try to export each resource after anonymisation, but this meant other resources sharing the same StudyInstanceUID were not exported.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #572 +/- ##
==========================================
- Coverage 87.51% 85.50% -2.02%
==========================================
Files 76 72 -4
Lines 3437 3235 -202
==========================================
- Hits 3008 2766 -242
- Misses 429 469 +40 ☔ View full report in Codecov by Sentry. |
04532e7
to
5a47136
Compare
784da58
to
28f92a6
Compare
In orthanc anon plugin, skip series that have few than min_instances_per_series instances
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we know the allowed_manufactures
we should add for each project?
in case the manufacturer doesn't exist
…ries_number_excluded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, but I think we need to be careful about despiad series to filter out. At least checking an example from each manufacturer for each modality to ensure that we're not exporting burned in PID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's nearly ready to merge, just a couple of questions about what defaults we want
- name: Series Date | ||
group: 0x0008 | ||
element: 0x0021 | ||
op: replace | ||
- name: Acquisition Date | ||
group: 0x0008 | ||
element: 0x0022 | ||
op: replace | ||
- name: Series Time | ||
group: 0x0008 | ||
element: 0x0031 | ||
op: keep | ||
- name: Acquisition Time | ||
group: 0x0008 | ||
element: 0x0032 | ||
op: keep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be replacing the times by default? Dave suggested we default to keeping them:
More information about the acquisition (reconstrution, randoms correction, etc) is also useful to ensure study protocol compliance in single and multi-centre studies. Acquisition time is a Level 1 attribute for PET series. And I think it may be worth keeping time to ensure uptake time, especially as in the PET base module all of the dates are either replace or wiped out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're probably okay but worth dropping Sophie an email to get her take on it from an IG perspective
Description
Closes #571
Closes #530
ensure all resources sharing aThis has already been fixed in Improve anon logging and anonymise all matching studies at once #582StudyInstanceUID
in Orthanc Raw are exported (they may exist as separate resources in Orthanc Raw if they have differentStudyID
s, but are combined into a single resource in Orthanc Anon as theStudyID
tag is deleted)Type of change
Please delete options accordingly to the description.
Suggested Checklist
main
branch.squash and merge