Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip whitespace and remove empty identifiers #586

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

stefpiatek
Copy link
Contributor

No description provided.

@stefpiatek stefpiatek requested a review from p-j-smith December 27, 2024 15:49
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.61%. Comparing base (807f84b) to head (1a0306f).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (807f84b) and HEAD (1a0306f). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (807f84b) HEAD (1a0306f)
8 5
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
- Coverage   87.24%   80.61%   -6.64%     
==========================================
  Files          76       64      -12     
  Lines        3380     3095     -285     
==========================================
- Hits         2949     2495     -454     
- Misses        431      600     +169     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ooo nice to see the reader more robust against input format

cli/src/pixl_cli/_database.py Show resolved Hide resolved
@stefpiatek stefpiatek enabled auto-merge (squash) January 7, 2025 10:11
@stefpiatek stefpiatek merged commit ecd5abf into main Jan 7, 2025
11 checks passed
@stefpiatek stefpiatek deleted the stefpiatek/whitespace_and_identifiers branch January 7, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants