Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker Compose profile for external PIXL DB #595

Closed
wants to merge 3 commits into from

Conversation

tomaroberts
Copy link
Contributor

@tomaroberts tomaroberts commented Jan 28, 2025

@p-j-smith, @stefpiatek – draft PR alternative approach to #593, to hopefully demonstrate this is along the right lines.

Uses Docker Compose profiles approach, as discussed in that PR. Thought simpler to start again from main rather than unpick the other one.

I've got two postgres containers running with ./run-system-test.sh, however the system-tests are failing hard. I can't figure out why yet. I think pixl cli is unable to communicate with system-test-postgres-external-1.

If either of you has a chance to pull the branch and investigate the system tests errors, let me know if you can diagnose, otherwise I'll keep at it.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.35%. Comparing base (4af6ed0) to head (a4c9fc2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #595      +/-   ##
==========================================
- Coverage   87.51%   85.35%   -2.17%     
==========================================
  Files          76       72       -4     
  Lines        3437     3169     -268     
==========================================
- Hits         3008     2705     -303     
- Misses        429      464      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefpiatek
Copy link
Contributor

If either of you has a chance to pull the branch and investigate the system tests errors, let me know if you can diagnose, otherwise I'll keep at it.

Looks like its passing in CI which is interesting.

@tomaroberts
Copy link
Contributor Author

If either of you has a chance to pull the branch and investigate the system tests errors, let me know if you can diagnose, otherwise I'll keep at it.

Looks like its passing in CI which is interesting.

The system-test was being skipped, which is what was failing.

Paul and I reverted to my previous PR/branch, so don't worry about this draft now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants