Skip to content

Commit

Permalink
Merge pull request #105 from SAP-samples/endresult-validation-issues-…
Browse files Browse the repository at this point in the history
…2023-07-10

Endresult validation issues 2023 07 10
  • Loading branch information
matthieupelatan authored Jul 10, 2023
2 parents 41ece04 + af6e841 commit b2b8e50
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
<fd-select v-model="actualYear" @update="updateData()">
<option value="2021">2021</option>
<option value="2022">2022</option>
<option value="2023">2023</option>
</fd-select>
</fd-form-item>
</fd-field-set>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
<fd-select v-model="actualYear" @update="updateData()">
<option value="2021">2021</option>
<option value="2022">2022</option>
<option value="2023">2023</option>
</fd-select>
</fd-form-item>
</fd-field-set>
Expand Down
2 changes: 1 addition & 1 deletion documentation/meter/deploy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ To execute all the necessary steps for the deployment, you will need the followi
* [Kubernetes CLI](https://kubernetes.io/docs/tasks/tools/#kubectl)
* [Kubernetes OpenID Connect (OIDC) authentication](https://github.com/int128/kubelogin)
* [jq](https://stedolan.github.io/jq/)
* [uuidgen](https://packages.ubuntu.com/bionic/uuid-runtime)
* [uuidgen](https://launchpad.net/ubuntu/bionic/+package/uuid-runtime)

**NOTE** If you use Windows, we recommend using a Linux subsystem for the mission as our scripts are only available as bash scripts. Furthermore, most of the examples around Kubernetes, for example, are written for Linux/MacOS environments. See [Install WSL](https://docs.microsoft.com/en-us/windows/wsl/install) in the Microsoft documentation for more details. If you have chosen to use Linux, you need to choose the Linux installation option for the mentioned tools.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ To demostrate how to expose custom metrics of your application through HTTP endp

The **DB service** uses **Hibernate** as object-relational mapping framework to persist domain model entities to a relational database. The [SynchronizedConnectionMap java class](https://github.com/SAP-samples/btp-kyma-multitenant-extension/blob/main/code/easyfranchise/source/backend/db-service/src/main/java/dev/kyma/samples/easyfranchise/dbservice/SynchronizedConnectionMap.java) make use of the **C3P0ConnectionProvider class**, provided by Hibernate. This connection provider uses a [C3P0 connection pool](https://www.mchange.com/projects/c3p0/).

To illustrate how custom metrics are exposed in [Prometheus format](https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels)<sup>[1](#OpenMetrics)</sup> through your own application, following example is provided:
To illustrate how custom metrics are exposed in [Prometheus format](https://prometheus.io/docs/concepts/data_model/#metric-names-and-labels) through your own application, following example is provided.
> Note: you can also use [Open Metrics](https://openmetrics.io/), which is a more vendor neutral format and successor of the Prometheus format.
[C3P0 DB connection pool metrics](../../../code/day2-operations/source/day2-service/src/main/java/dev/kyma/samples/easyfranchise/day2/rest/jmx/C3P0ConnectionPoolMetricsScheduler.java) implemented using [Prometheus Java client](https://github.com/prometheus/client_java). In our DB-service [c3p0 pool](https://www.mchange.com/projects/c3p0/) is used to access the database of the Easy Franchise application. We collected the following metrics to provide a real-time monitoring of the database connecion usage for each of the subscribed tenants:

- db_number_connections_all_users
Expand Down Expand Up @@ -244,6 +246,3 @@ spec:
}
```

## Reference:

<a name="OpenMetrics">1</a>: [OpenMetrics](https://openmetrics.io/) format is a more vendor neutral succssor of the Prometheus format

0 comments on commit b2b8e50

Please sign in to comment.