-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init.js revisited #538
init.js revisited #538
Conversation
I guess this works now but still seems a bit like a workaround to me that the init.js defers the actual initialization to a later point in time. I know why we do it but not really intuitive if I don't know the reuse cases of bookshop. |
Yes, fully agreed, that's why we still didn't document it and shouldn't promote it. |
Any idea why these Fiori v2 tests fail? |
could be a new proxy version |
You are right, v2 proxy@1.11 seems to have changed former hard-coded |
Follow up to #535
Ok, sorry, I tested with the existing bookstore sample, which has a similar reference to common data, and init.js was called after importing conflicting .csv files. But in this tests it is the other way around ...
I'd propose to change the implementation to this one to demonstrate best practices