Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check z_generate_repo by abaplint #282

Merged
merged 20 commits into from
Oct 11, 2023
Merged

Check z_generate_repo by abaplint #282

merged 20 commits into from
Oct 11, 2023

Conversation

albertmink
Copy link
Contributor

@albertmink albertmink commented Sep 11, 2023

This PR makes report z_generate_repo fit to pass abapLint checks 💪

The value help will no longer be alphabetically sorted, see
Screenshot 2023-10-09 at 13 48 30

After #281 as there is a new keyword STEP

@albertmink
Copy link
Contributor Author

For now ignoring local classes ltc_generator_double and ltc_generator as they are non-productive coding.

@larshp
Copy link
Collaborator

larshp commented Sep 26, 2023

https://rules.abaplint.org/indentation/

try setting "selectionScreenBlockIndentation": true,

@larshp
Copy link
Collaborator

larshp commented Sep 26, 2023

"indentation": {
  "selectionScreenBlockIndentation": true
},

@larshp
Copy link
Collaborator

larshp commented Sep 26, 2023

db_operation_in_loop: for now, just exclude the program in the rule setting

@albertmink albertmink marked this pull request as ready for review October 9, 2023 11:45
@albertmink albertmink changed the title Include all, don't be exclusive Check z_generate_repo by abaplint Oct 9, 2023
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@albertmink albertmink merged commit 3ec4c64 into main Oct 11, 2023
@albertmink albertmink deleted the minka/abaplint-4all branch October 11, 2023 12:45
@albertmink albertmink mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants