-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDOI] Add new object types EDOI #681
base: main
Are you sure you want to change the base?
Conversation
|
Hi @i506210, Thank you for your contribution. Would you mind to split this pull request (PR) into two PRs? One for EDOI and one for EDOT. I believe the handling for one PR per object type will be easier. Furthermore, you might want to remove the Thanks :) |
Hi @schneidermic0, I have split Pull request into 2 and triggered PR. could you please check Thanks & REgards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Venkat,
thanks for the update. I've added some questions/comments to your pull request.
Please note, that for the title and description, we use title case and sentence case respectively. I've not marked every occurrence but if you could please adjust that.
"! <p class="shorttext">Interface Version</p> "<- title (title case)
"! Interface version "<- description (sentence case)
Hi
Hi Michael, I corrected all the places. Thanks & Regards, |
No description provided.