-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SXTG] Add new object type SXTG #687
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Robin, thanks for your contribution. Your AFF already looks pretty good, I mainly have some comments regarding texts/naming.
One further question regarding the object type itself: SAP GUI Extension Points sound not like something that will be available in the cloud. Can you shortly explain your object type?
And one last question, is this an already existing object type or new development?
Hi Marcus, The object type “SAP GUI Extension Point” supports possibility to add Extension Fields created via Developer Extensibility (ALV 5 “ABAP for Cloud Development”) in ADT to SAP GUI screens. So it is available in Cloud. A customer has to know the following objects stored in the “SAP GUI Extension Point” to extend a SAP UI transaction:
Also, to answer your question, this is a new development. Best regards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Robin, thanks for the explanation.
Sorry for the maybe confusing suggestions about upper/lower case styling in our title/descriptions. We require title case for titles and sentence case for descriptions:
"! <p class="shorttext">Title Case</p>
"! Sentence case
I've marked four instances below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Robin,
thanks for the update. Looks pretty good so far. I found one minor typo, could you please correct this?
Could you also provide an example JSON on how a serialized object will look like? Depending on how far your development is, you can either do this with our SAFF_GENERATE_REPO
program by defining an already existing object as "Example Object Name" or you can use a tool like JSON Schema Faker and input the schema to generate a valid JSON. You can then modify the JSON to represent one example object with some realistic values.
Please upload your example json with the name z_aff_example_sxtg.sxtg.json
into the folder file-formats/sxtg/examples/
and link it in the README.md
by adding the following snippet to the end of the table.
| [
z_aff_example_sxtg.sxtg.json](./examples/z_aff_example_sxtg.sxtg.json)
Thanks
"! Transaction code | ||
BEGIN OF ty_transaction_code, | ||
"! <p class="shorttext">Transaction Code</p> | ||
"! Transaction codes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"! Transaction codes | |
"! Transaction code |
No description provided.