Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SXTG] Add new object type SXTG #687

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

robinPfaffSap
Copy link

No description provided.

Copy link

cla-assistant bot commented Feb 18, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

cla-assistant bot commented Feb 18, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@huber-nicolas huber-nicolas added the new-object This is a new object type added to AFF label Feb 27, 2025
Copy link
Member

@Markus1812 Markus1812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Robin, thanks for your contribution. Your AFF already looks pretty good, I mainly have some comments regarding texts/naming.

One further question regarding the object type itself: SAP GUI Extension Points sound not like something that will be available in the cloud. Can you shortly explain your object type?

And one last question, is this an already existing object type or new development?

@robinPfaffSap
Copy link
Author

Hi Marcus,

The object type “SAP GUI Extension Point” supports possibility to add Extension Fields created via Developer Extensibility (ALV 5 “ABAP for Cloud Development”) in ADT to SAP GUI screens. So it is available in Cloud.
The application includes a generic subscreen in their application UI, creates an abstract entity and applies the C0 contract for developer extensibility. This UI extension entity decides what fields are rendered on the dynpro UI.
Customers create extends for the abstract entity based on their extension fields from persistence Extension Include. All major properties are derived from the field definition (Texts, field type, value help support).

A customer has to know the following objects stored in the “SAP GUI Extension Point” to extend a SAP UI transaction:

  • Extension Include (included in DB table and contains appended Developer Extension Fields)
  • Application Data Structure (read-only application data for customer which at least contain key fields e.g. to validate or calculate Developer Extension Fields)
  • UI Extension Entity (abstract entity which contains fields to be rendered on dynpro UI)

Also, to answer your question, this is a new development.

Best regards
Robin

Copy link
Member

@Markus1812 Markus1812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Robin, thanks for the explanation.

Sorry for the maybe confusing suggestions about upper/lower case styling in our title/descriptions. We require title case for titles and sentence case for descriptions:

"! <p class="shorttext">Title Case</p>
"! Sentence case

I've marked four instances below.

Copy link
Member

@Markus1812 Markus1812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Robin,

thanks for the update. Looks pretty good so far. I found one minor typo, could you please correct this?

Could you also provide an example JSON on how a serialized object will look like? Depending on how far your development is, you can either do this with our SAFF_GENERATE_REPO program by defining an already existing object as "Example Object Name" or you can use a tool like JSON Schema Faker and input the schema to generate a valid JSON. You can then modify the JSON to represent one example object with some realistic values.

Please upload your example json with the name z_aff_example_sxtg.sxtg.json into the folder file-formats/sxtg/examples/ and link it in the README.md by adding the following snippet to the end of the table.
| [z_aff_example_sxtg.sxtg.json](./examples/z_aff_example_sxtg.sxtg.json)

Thanks

"! Transaction code
BEGIN OF ty_transaction_code,
"! <p class="shorttext">Transaction Code</p>
"! Transaction codes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"! Transaction codes
"! Transaction code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-object This is a new object type added to AFF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants