-
Notifications
You must be signed in to change notification settings - Fork 136
fix(core): enable segmented button #12808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Visit the preview URL for this PR (updated for commit 1fe8e91): https://fundamental-ngx-gh--pr12808-fix-segmented-button-wlabhtl9.web.app (expires Sat, 08 Feb 2025 12:35:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
67d1acd
to
47c99d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does allow the segmented button to be focused again, however I can no longer use the arrow keys to change the selected segment. Still working for the other examples, I'm just seeing this problem on the newly modified example
I can confirm the same thing. The arrow keys are not working. Also, I would suggest an improvement for the example. Add a button that programatically disables and enables the Segmented button. Additionally, explain in a 2-3 short sentences what this example is doing. Right now, with the short timeout, for people that don't have an idea what the issue is, it's not very clear why we have this example. |
fixed! |
2ad5fe2
to
fa30ef7
Compare
5c11b11
to
0963dc7
Compare
I am not seeing an update regarding Inna's documentation suggestions Also, while I am seeing the arrow key focus problem is fixed, I can no longer use enter/space to change the selection on this example |
like @mikerodonnell89 said, enter/space does not change the selection in the reactive form. Also, clicking it with a mouse only focuses it but doesn't change the value/selection. |
b174320
to
5a0e288
Compare
9d2983d
to
bdc004c
Compare
ac6591a
to
1fe8e91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screen.Recording.2025-02-05.at.9.59.47.AM.mov
There's hover state on the selected button and using arrow keys focus the entire segmented button.
fixes #12675
fix enable segmented button
delete e2e as the unit tests cover the testing enough