fix(core, platform): only check empty content when table cell is focused #13395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
CSEHoangV
changed the title
CSEHoangV
force-pushed
the
fix/main-tablerowperf
branch
2 times, most recently
from
1c5fdc6 to
24eb955
Compare
CSEHoangV
changed the title
CSEHoangV
force-pushed
the
fix/main-tablerowperf
branch
3 times, most recently
from
7e29cdb to
fd88021
Compare
CSEHoangV
changed the title
CSEHoangV
force-pushed
the
fix/main-tablerowperf
branch
from
fd88021 to
0d1bab2
Compare
|
We will leave this to @mikerodonnell89 to review |
mikerodonnell89
requested changes
Sep 24, 2025
libs/platform/table/components/table-row/table-row.component.ts
Outdated
Show resolved
Hide resolved
CSEHoangV
changed the title
CSEHoangV
force-pushed
the
fix/main-tablerowperf
branch
from
ee0fedc to
73642a5
Compare
|
Still stuck with current work, I will revisit and make a suggested change later. |
|
@CSEHoangV Let's close it for now, you can reopen it whenever you have more time |
CSEHoangV
force-pushed
the
fix/main-tablerowperf
branch
from
73642a5 to
4b91e31
Compare
… when cell is focused fix(platform): add option for empty cell announcement for column template
CSEHoangV
force-pushed
the
fix/main-tablerowperf
branch
from
4b91e31 to
cafbdba
Compare
CSEHoangV
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
fix #11899
Description
Please refer to #12021 for more information, it was later closed and change was included in #12015. However, we only needed change from #12021 to fix performance since root cause came from the
innerText.For the fix in the main branch, implementation is changed a bit to narrow down on when we should check and do the screen reading in this case. The screenreader should only be occurred when table cell is focused. Therefore, condition checking should happen at that time to avoid the DOM check for every table cell when it is rendered.
The fix also combines implementation from #10512 with a bit modifications and scenario narrowed down. DOM access checking should be occurred when this comes from custom table cell as we don't know if application display content or not.
Add a way to stop default announcement and expected consumer provide their own announcement on column template.
Our application is in the process of migrating to Angular 20. We would like to migrate some of the fixes which only exist in Angular 15 downport to main branch.