Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(581): open extension links in extension #585

Merged
merged 4 commits into from
Dec 28, 2023

Conversation

oliversberzs
Copy link
Contributor

Issue

#581

Description

  • Open links that point to extension nodes in extension and not in the browser

@oliversberzs oliversberzs requested a review from a team as a code owner December 22, 2023 10:12
Copy link

changeset-bot bot commented Dec 22, 2023

🦋 Changeset detected

Latest commit: cfa3dad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
sap-guided-answers-extension Patch
@sap/guided-answers-extension-types Patch
@sap/guided-answers-extension-webapp Patch
@sap/guided-answers-extension-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

Copy link
Member

@unseen1980 unseen1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, I haven't tested it though. Thanks @oliversberzs

@oliversberzs oliversberzs merged commit 2c42aeb into main Dec 28, 2023
14 checks passed
@oliversberzs oliversberzs deleted the feat/581/open-links-in-extension branch December 28, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants