chore(deps-dev): bump braces from 3.0.2 to 3.0.3 #602
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
|
| @@ -7131,7 +7146,7 @@ packages: | |||
| resolution: {integrity: sha512-DMy+ERcEW2q8Z2Po+WNXuw3c5YaUSFjAO5GsJqfEl7UjvtIuFKO6ZrKvcItdy98dwFI2N1tg3zNIdKaQT+aNdA==} | |||
| engines: {node: '>=8.6'} | |||
| dependencies: | |||
| braces: 3.0.2 | |||
| braces: 3.0.3 | |||
There was a problem hiding this comment.
This change looks incorrect. Seems like dependabot made a direct change in the lock file.
Running pnpm update does not update the entry to 3.0.3
There was a problem hiding this comment.
Okay this seems also correct, but I wonder why the specifier "^" is not mentioned in the lock file
I checked the code and the following dependency is listed in the package.json of micromatch@4.0.5
"dependencies": {
"braces": "^3.0.2",
"picomatch": "^2.3.1"
},
There was a problem hiding this comment.
Dependabot (and renovate for that mater) do not fully understand how to write overrides, so they just make direct lock changes.
These can work sometimes, but is not always consistent.
Such as for braces, which is always referenced as ^3 (that I have seen), this is OK.
For PNPM you can use the following cli as well:
pnpm update braces
| @@ -6731,7 +6746,7 @@ packages: | |||
| dependencies: | |||
| universalify: 2.0.0 | |||
| optionalDependencies: | |||
| graceful-fs: 4.2.10 | |||
| graceful-fs: 4.2.11 | |||
There was a problem hiding this comment.
This update looks correct when I check the package.json of the jsonfile module
It has the following entry:
"optionalDependencies": {
"graceful-fs": "^4.1.6"
},
There was a problem hiding this comment.
It is best to also update the optional to be ^4.2.11
There was a problem hiding this comment.
Thanks for answering @donal-tobin-sap, but this has to be done manually if I understand correctly.
Shouldn't this be doable by some pnpm command or maybe this is just a gap in pnpm as I do not see the usage of ^ in dependencies and optionalDependencies, but only in peeerDependencies section
There was a problem hiding this comment.
Yes, some manual work will be required.
Renovate (nor dependabot) do not do everything.
|
|
This issue should get fixed by #603 Edit: Issue is fixed |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps braces from 3.0.2 to 3.0.3.
Commits
74b2db23.0.388f1429update eslint. lint, fix unit tests.415d660Snyk js braces 6838727 (#40)190510ffix tests, skip 1 test in test/braces.expand716eb9freadme bumpa5851e5Merge pull request #37 from coderaiser/fix/vulnerability2092bd1feature: braces: add maxSymbols (https://github.com/micromatch/braces/issues/...9f5b4cffix: vulnerability (https://security.snyk.io/vuln/SNYK-JS-BRACES-6838727)98414f9remove funding file665ab5dupdate keepEscaping doc (#27)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.