Skip to content

chore: update axios for security and pretty-quick #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

hitesh-parmar
Copy link
Contributor

@hitesh-parmar hitesh-parmar commented Aug 23, 2024

Issue

https://github.com/SAP/guided-answers-extension/security/dependabot/15

Description

Update axios to 1.7.4 to solve security issues.

An update of pretty-quick was also required to solve an issue with unmet peer dependency. As a result pre commit husky check was also failing.

Checklist for Pull Requests

  • Supplied as many details as possible on this change
  • Included the link to the associated issue in the Issue section above
  • The code conforms to the general development guidelines.
  • The code has unit tests where applicable and is easily unit-testable
  • This branch is appropriately named for the associated issue

@hitesh-parmar hitesh-parmar self-assigned this Aug 23, 2024
Copy link

changeset-bot bot commented Aug 23, 2024

🦋 Changeset detected

Latest commit: 265c8c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@sap/guided-answers-extension-core Patch
sap-guided-answers-extension Patch
@sap/guided-answers-extension-types Patch
@sap/guided-answers-extension-webapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hitesh-parmar hitesh-parmar marked this pull request as ready for review August 23, 2024 11:48
@hitesh-parmar hitesh-parmar requested a review from a team as a code owner August 23, 2024 11:48
Copy link

@hitesh-parmar hitesh-parmar merged commit 38f3290 into main Aug 23, 2024
12 checks passed
@hitesh-parmar hitesh-parmar deleted the chore/security/axios branch August 23, 2024 11:58
@hitesh-parmar hitesh-parmar added the dependencies Pull requests that update a dependency file label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants