Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Container: set svelte component context variable on ctx update #4051

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Container: set svelte component context variable on ctx update #4051

merged 5 commits into from
Dec 13, 2024

Conversation

hardl
Copy link
Contributor

@hardl hardl commented Dec 4, 2024

partially fixes #4048

@hardl hardl changed the title set svelte component context variable on ctx update Container: set svelte component context variable on ctx update Dec 4, 2024
@JohannesDoberer JohannesDoberer self-assigned this Dec 5, 2024
@JohannesDoberer JohannesDoberer marked this pull request as ready for review December 12, 2024 12:31
walmazacn
walmazacn approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@walmazacn walmazacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@JohannesDoberer JohannesDoberer merged commit 8f23963 into main Dec 13, 2024
12 checks passed
@JohannesDoberer JohannesDoberer deleted the store-context-state branch December 13, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmazacn walmazacn walmazacn approved these changes

@JohannesDoberer JohannesDoberer Awaiting requested review from JohannesDoberer JohannesDoberer is a code owner

@ndricimrr ndricimrr Awaiting requested review from ndricimrr ndricimrr is a code owner

@VincentUllal VincentUllal Awaiting requested review from VincentUllal VincentUllal is a code owner

@smahati smahati Awaiting requested review from smahati smahati is a code owner

@amilewskaa amilewskaa Awaiting requested review from amilewskaa amilewskaa is a code owner

Assignees

@JohannesDoberer JohannesDoberer

Labels
container dxp headless-core ora ora related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container: consistent handling of props, attributes and svelte component variables
3 participants
@hardl @walmazacn @JohannesDoberer