Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maintain list of supported ui5 versions #2638

Open
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

nahmed22
Copy link
Member

introduces a detailed table documenting the minimum supported SAPUI5 versions for each quick action across V2 and V4 frameworks.

@nahmed22 nahmed22 requested a review from a team as a code owner November 28, 2024 21:41
Copy link

changeset-bot bot commented Nov 28, 2024

⚠️ No Changeset found

Latest commit: 2bb734c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nahmed22 nahmed22 added the control-property-editor @sap-ux/control-property-editor label Nov 28, 2024
vadson71
vadson71 previously approved these changes Nov 29, 2024
@nahmed22 nahmed22 requested review from voicis and vadson71 November 29, 2024 12:42
@MN-public
Copy link

MN-public commented Dec 5, 2024

@nahmed22 I would suggest to include the information on the relevant pages and maybe update the header and maybe update the header/ simplify the text. Could you please check it for correctness and take over if it makes sense?

Supported UI5 Versions for Quick Actions in Adaptation Projects Based on Fiori Elements Applications with OData V2 and OData V4

Quick Action OData Version Page Type SAPUI5 1.71 SAPUI5 1.84 SAPUI5 1.96 SAPUI5 1.108 SAPUI5 1.120 SAPUI5 1.24 SAPUI5 1.27 SAPUI5 1.130 SAPUI5 1.131 onwards
Add Controller to Page OData V2 List Report, Object Page X X X X X X X X X
OData V4 List Report, Object Page X X X X X X X X X
Add Header Field OData V2 Object Page X X X X X X X X X
OData V4 Object Page X X X X X X X X X
Add Custom Section OData V2 Object Page X X X X X X X X X
OData V4 Object Page X X X X X X X X X
Add Custom Page Action OData V2 List Report, Object Page X X
OData V4 List Report, Object Page X X
Add Custom Table Action OData V2 List Report, Object Page X X X X X X X
OData V4 List Report, Object Page X X X X X X X
Add Custom Table Column OData V2 List Report, Object Page X X X X X X X
OData V4 List Report, Object Page X X X X X X X
Change Table Columns OData V2 List Report, Object Page X X X X X X X
OData V4 List Report, Object Page X X X X X X X
Enable/Disable "Clear" Button OData V2 List Report X X X X X X X X X
OData V4 List Report X X X X X X X X X
Enable Semantic Date Range* OData V2 List Report X X X X X X
OData V4 List Report X X X
Enable Table Filtering for Page Variants* OData V2 List Report, Object Page X X X X X X
OData V4 List Report, Object Page X

*Actions resulting in manifest changes are not available for adaptation projects built for older OData v2 appliactions using array page structure in manifest.json.

Update the table title
Include Page Type
Add note on availability of manifest changes in older V2 apps
Copy link

cla-assistant bot commented Dec 5, 2024

CLA assistant check
All committers have signed the CLA.

vadson71
vadson71 previously approved these changes Dec 5, 2024
@nahmed22 nahmed22 requested a review from vadson71 January 8, 2025 13:11
Copy link

sonarqubecloud bot commented Jan 8, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
control-property-editor @sap-ux/control-property-editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants