-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update quick action on file change on workspace #2755
Conversation
🦋 Changeset detectedLatest commit: 06643d7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…reloadQuickActionOnExternalFileChange # Conflicts: # packages/adp-tooling/src/preview/routes-handler.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
Coverage is good
Did not test manually
packages/adp-tooling/src/writer/changes/writers/annotations-writer.ts
Outdated
Show resolved
Hide resolved
…ithub.com/SAP/open-ux-tools into fix/reloadQuickActionOnExternalFileChange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good
Coverage is good
Comments addressed
Did not test manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code changes looks good
- Good test coverage
- Review comments addressed
- Tested locally
Contains fix for updating the quick action list when changes are made externally via generators/or manually by the user in workspace. For eg: There are generators to add or replace odata service so the running app should react to the change and update the quick action list.
Also covers the comments uncovered in PR
#2618