Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update quick action on file change on workspace #2755

Merged
merged 17 commits into from
Jan 13, 2025

Conversation

Jimmy-Joseph19
Copy link
Contributor

@Jimmy-Joseph19 Jimmy-Joseph19 commented Jan 9, 2025

Contains fix for updating the quick action list when changes are made externally via generators/or manually by the user in workspace. For eg: There are generators to add or replace odata service so the running app should react to the change and update the quick action list.

Also covers the comments uncovered in PR
#2618

@Jimmy-Joseph19 Jimmy-Joseph19 requested review from a team as code owners January 9, 2025 05:04
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 06643d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@sap-ux-private/control-property-editor-common Patch
@sap-ux-private/preview-middleware-client Patch
@sap-ux/control-property-editor Patch
@sap-ux/preview-middleware Patch
@sap-ux/adp-tooling Patch
@sap-ux/create Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/flp-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Jimmy-Joseph19 Jimmy-Joseph19 changed the title reload quick action on file change on workspace update quick action on file change on workspace Jan 9, 2025
@Jimmy-Joseph19 Jimmy-Joseph19 requested a review from a team as a code owner January 9, 2025 18:38
@nikmace nikmace self-requested a review January 13, 2025 09:38
@vadson71 vadson71 changed the title update quick action on file change on workspace fix: update quick action on file change on workspace Jan 13, 2025
Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good
Coverage is good
Did not test manually

@nikmace nikmace self-requested a review January 13, 2025 10:09
@nikmace nikmace requested review from nikmace and voicis January 13, 2025 16:36
nikmace
nikmace previously approved these changes Jan 13, 2025
Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good
Coverage is good
Comments addressed
Did not test manually

Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code changes looks good
  • Good test coverage
  • Review comments addressed
  • Tested locally

@voicis voicis merged commit f115bfa into main Jan 13, 2025
16 checks passed
@voicis voicis deleted the fix/reloadQuickActionOnExternalFileChange branch January 13, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants