Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for external HTTP calls #2806

Merged
merged 11 commits into from
Jan 24, 2025
Merged

Conversation

nlunets
Copy link
Member

@nlunets nlunets commented Jan 22, 2025

When doing component based testing it might be useful to refer to an actual mockserver.

Furthermore if we want to leverage more complex snapshot (including screenshots), being able to load CSS is desired, so an option was added for that.

When doing component based testing it might be useful to refer to an actual mockserver.
Furthermore if we want to leverage more complex snapshot (including screenshots), being able to load CSS is desired, so an option was added for that
@nlunets nlunets requested a review from a team as a code owner January 22, 2025 08:20
Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 0e53dcd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/jest-environment-ui5 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nlunets nlunets force-pushed the feat/jestExternalCalls branch from 576955a to c939e67 Compare January 23, 2025 08:29
@voicis voicis self-requested a review January 23, 2025 09:36
@nlunets nlunets force-pushed the feat/jestExternalCalls branch from 8930c83 to e2e84ae Compare January 23, 2025 12:53
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Changes looks good
  • Changeset present
  • Did not test locally

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Changeset is good.
Tests are good.

@nlunets nlunets merged commit 754a4e6 into main Jan 24, 2025
16 checks passed
@nlunets nlunets deleted the feat/jestExternalCalls branch January 24, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants