Feat(app-config-writer): enhance prompt for convert preview config

[heimwege]

• adjust prompt to ask for simulation
• add new prompt asking to include test conversion

[changeset-bot]

🦋 Changeset detected

Latest commit: f059aee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@sap-ux/app-config-writer	Patch
@sap-ux/create	Patch
@sap-ux/flp-config-sub-generator	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[heimwege]

@Klaus-Keller I just saw that the prompts for e.g. smartlinks-config are located in app-config-writer and imported into create whereas this PR would add the prompts for convert preview-config directly to the create module. Has there been any alignment on where to place the prompts?

And do you know where the @sap-ux/flp-config-sub-generator entry comes from in the changeset-bot entry? It's not part of the actual changeset md of this PR 🤷🏻

[Klaus-Keller]

@Klaus-Keller I just saw that the prompts for e.g. smartlinks-config are located in app-config-writer and imported into create whereas this PR would add the prompts for convert preview-config directly to the create module. Has there been any alignment on where to place the prompts?

Ideally, the @sap-ux/create module has a very slim feature implementation and as few as possible domain knowledge about the actual feature. Preferably, prompts are with the feature, in this case they should be in preview-config.

And do you know where the @sap-ux/flp-config-sub-generator entry comes from in the changeset-bot entry? It's not part of the actual changeset md of this PR 🤷🏻

Not sure about this.

[lfindlaysap]

@heimwege, here is my UA review at the request of Annemarie. @JannaLisa

[JannaLisa]

@heimwege, here is my UA review at the request of Annemarie. @JannaLisa

All changes proposed by @lfindlaysap look good to me!
The only tiny question I'd have is whether an article is missing: Do you want to convert the test runners?

[ytpo-lyne]

• changes to prompting look good
• changeset exists
• language reviews set-in
• test coverage is excellent
• tested locally, no issues found

Thanks, @heimwege!

[Klaus-Keller]

Thanks @heimwege!

• focused my review on @sap-ux/create
• code change and additions for simulation look good
• changeset exits
• test coverage is great
• did a visual review, no manual test

Approved from my side

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud