fix(backend-proxy-middleware): add missing 'express' dependency #3847
Conversation
🦋 Changeset detectedLatest commit: 32b9403 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
@devinea third party contribution still seem to break the pipeline |
|
@matz3 thanks for finding this one. I'll follow up on the |
matz3
force-pushed
the
backend-proxy-middleware/add-missing-express-dependency
branch
from
afa9412 to
461fa9f
Compare
|
@heimwege thank you. I've added a changeset to the existing commit. |
The dependency was only used as devDependency before, but since recent changes (SAP#3032) the dependency is now required at runtime as well (express.Router).
matz3
force-pushed
the
backend-proxy-middleware/add-missing-express-dependency
branch
from
461fa9f to
6a33df8
Compare
|
Not to self: same issue seems to exist for ui5-proxy-middleware. Check #540 |
|
…riter/unique-ids-in-fragment * 'main' of github.com:SAP/open-ux-tools: (34 commits) chore: apply latest changesets feat(fiori-mcp-server): add generate-fiori-ui-odata-app functionality (#3570) chore: apply latest changesets fix(backend-proxy-middleware): simplify usage of types (#3870) chore: apply latest changesets fix: Bump @sap/manifest version (#3872) chore: apply latest changesets fix(backend-proxy-middleware): add missing 'express' dependency (#3847) chore: apply latest changesets fix unstable fiori tools settings test (#3864) feat(create): enable card generator for CAP projects (#3868) fixing issues accessing `secrets` on forks (#3876) Increase test timeout from 60s to 120s (#3875) chore: apply latest changesets feat: menu actions generator (#3521) chore: apply latest changesets chore: remove mkdirp usage and update dependencies (#3871) chore: apply latest changesets feat: save value list reference metadata (#3794) chore: apply latest changesets ...
3 participants
The dependency was only used as devDependency before, but since recent changes (#3032) the dependency is now required at runtime as well (express.Router).
An alternative to express.Router is the router package, which provides the same functionality. We're using that package in our built-in "csp" middleware in UI5 CLI.