Fix: Change custom page action creation from addXML to appDescr change #3848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 842140c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Jimmy-Joseph19
changed the title
lfindlaysap
requested changes
Nov 24, 2025
Contributor
lfindlaysap
left a comment
lfindlaysap
left a comment
There was a problem hiding this comment.
@Jimmy-Joseph19, is it a limitation of the TypeScript where the error messages are inline rather than a messagebundle or i18n file.
| '@sap-ux/preview-middleware': patch | ||
| --- | ||
|
|
||
| Fix: Switch Page Action creation for v4 from addXML to appDescriptor based |
Contributor
There was a problem hiding this comment.
Suggested change
| Fix: Switch Page Action creation for v4 from addXML to appDescriptor based | |
| Fix: Switch Page Action creation for OData V4 from addXML to appDescriptor based |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch Page Action creation from addXML to appDescriptor-based.