Fixed runtime conversion of 2d Arrays #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code in the test case is lifted from the following call: `org.apache.logging.log4j.core.util.datetime.FastDateParser$TimeZoneStrategy.<init>` This did fail before, because Fontus did not detect String[][] as something it can convert. This adds the required logic to the ConversionUtils. This adds an additional branch in the hot path, so might have performance impact..
tmbrbr
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in the test case is lifted from the following call:
org.apache.logging.log4j.core.util.datetime.FastDateParser$TimeZoneStrategy.<init>This failed before because Fontus did not detect String[][] as something it could convert. This adds the required logic to the ConversionUtils.
This adds an additional branch in the hot path, so it might have a performance impact. The comment above the isHandleable() method rings very true indeed.