Added support for default Properties. #17
Merged
+44
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Properties class is a thorn in our side since basically forever. We have something in place that mostly works, but sometimes goes up in a ball of flames. I found a case of the latter today. Unlike the JDK Properties, ours did not expose the defaults field which allows to delegate lookup to an upper Property map. This fixes the presence and usage of the defaults field. It's still not fully supported, as we e.g., do not write out the default keys when `stringPropertyNames()` is called.
leeN
added
bug
leeN
force-pushed
the
default_properties
branch
from
818b66e to
6d70c40
Compare
tmbrbr
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Properties class is a thorn in our side since basically forever. We have something in place that mostly works, but sometimes goes up in a ball of flames. I found a case of the latter today.
Unlike the JDK Properties, ours did not expose the defaults field which allows to delegate lookup to an upper Property map. This fixes the presence and usage of the defaults field.
It's still not fully supported, as we e.g., do not write out the default keys when
stringPropertyNames()is called.