Skip to content

[DEPENDENCY] Bump ajv from 6.12.6 to 8.6.3#427

Open
matz3 wants to merge 2 commits intov2from
ajv-v8
Open

[DEPENDENCY] Bump ajv from 6.12.6 to 8.6.3#427
matz3 wants to merge 2 commits intov2from
ajv-v8

Conversation

@matz3
Copy link
Copy Markdown
Member

@matz3 matz3 commented Oct 6, 2021

JIRA: CPOUI5FOUNDATION-859

@flovogt flovogt changed the base branch from master to v2 November 3, 2022 13:31
d3xter666 added a commit to UI5/cli that referenced this pull request Mar 10, 2026
….0.1 to 3.0.0 (#1309)

JIRA: CPOUI5FOUNDATION-859

PoC resolution in v4: SAP/ui5-project#427
v4 implementation: SAP/ui5-project#860

### Performance
There's a slight performance degradation after the update. This is an
expected behaviour as the code behind the generated validation function
has evolved. They have added more comprehensive checks in there and more
verbose logging. This is clearly visible in the coverage reports that we
have integrated for tha function in our test scenarios.

#### Comparisson

Command: `time ui5 build`

##### sap.m

###### After
info ProjectBuilder Build succeeded in 18 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  36.37s user 11.09s system 246% cpu 19.237 total

###### Before
info ProjectBuilder Build succeeded in 17 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  35.54s user 10.14s system 247% cpu 18.480 total

---

##### sap.ui.core

###### After
info ProjectBuilder Build succeeded in 9.42 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  23.09s user 5.16s system 276% cpu 10.212 total

###### Before
info ProjectBuilder Build succeeded in 9.43 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  22.54s user 5.43s system 273% cpu 10.242 total
d3xter666 added a commit that referenced this pull request Mar 10, 2026
…o 3.0.0 (#860)

JIRA: CPOUI5FOUNDATION-859

PoC resolution in v4: #427

v5 implementation: UI5/cli#1309

### Performance
There's a slight performance degradation after the update. This is an
expected behaviour as the code behind the generated validation function
has evolved. They have added more comprehensive checks in there and more
verbose logging. This is clearly visible in the coverage reports that we
have integrated for tha function in our test scenarios.

#### Comparisson

Command: `time ui5 build`

##### sap.m

###### After
info ProjectBuilder Build succeeded in 18 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  36.37s user 11.09s system 246% cpu 19.237 total

###### Before
info ProjectBuilder Build succeeded in 17 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  35.54s user 10.14s system 247% cpu 18.480 total

---

##### sap.ui.core

###### After
info ProjectBuilder Build succeeded in 9.42 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  23.09s user 5.16s system 276% cpu 10.212 total

###### Before
info ProjectBuilder Build succeeded in 9.43 s  
info ProjectBuilder Executing cleanup tasks...  
ui5 build  22.54s user 5.43s system 273% cpu 10.242 total
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant