fix(ui5-button): prevents native behavior when click prevented #11678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didip1000
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
The fix works but i'd like @tsanislavgatev to look over the changes before submitting.
tsanislavgatev
approved these changes
Jun 10, 2025
|
🎉 This PR is included in version v2.12.0-rc.0 🎉 The release is available on v2.12.0-rc.0 Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native click behavior triggered by the
ui5-buttonis not suppressed based on the custom event fired by the web component. Although the nativeclickevent does not propagate, its default behavior still occurs—even when the custom event is prevented.With this PR, the native behavior is now correctly prevented when the custom event is prevented.
Fixes: #11653