-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
general processor improvements #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they might be reused when processing neighboring scenes
… if ei does not contain valid data
…/snap_proc # Conflicts: # S1_NRB/config.py
the prefix 'slc_' is not applicable since edge cleaning is applied to GRDs too
I have a hunch that with the latest changes (or even before that) the function nrb.format and the underlying nrb.get_datasets don't ensure that incomplete tiles are created. This needs to be checked before merging this PR. Will get to it next week. @maawoo, FYI. |
Before a scene was just removed from the list if no output was found. This could result in incomplete tiles.
Before incomplete tiles could be created at the ends of a data take group because all tiles overlapping with the scenes were considered. Now a second scene search is performed with the preselected tiles as input geometry and an extended time range so that pre- and succeeding scenes are selected as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves on the general processing workflow stability:
snap_gpt_args
enables parametrization of the underlying SNAP GPT call; this has been found particularly relevant in an HPC environment where SNAP may try to use more resources than ordered in the SLURM job; all functions of theS1_NRB.snap
have been extended with an argumentgpt_args
accordinglyutm_multi
enables processing to a single UTM zone if set to False; this is only intended for debugging and experimentation purposesfurther bug fixes:
aoi_tiles
andaoi_geometry
undefined), ensure full tile coverage at the ends of the data take groups