Add Tolerances to 2D Search and begin 3D Search Implementation#214

Open

matthew-mccall wants to merge 25 commits intoSCOREC:developfrom

matthew-mccall:2d-tolerance-search

Commits on Feb 19, 2026

Refactor GridPointSearch to support dimensional template specialization.
matthew-mccall
committed
Switch `optional` to `unique_ptr`
matthew-mccall
committed
Add 3D grid point search functionality and refactor 2D implementation
matthew-mccall
committed
Replace custom barycentric_from_global with Omega_h implementation
matthew-mccall
committed
Add bbox_verts_within_simplex function and virtual destructor
matthew-mccall
committed
Refactor point search to support 3D grids.
matthew-mccall
committed
Add REGION dimensionality to point search
matthew-mccall
committed
Refactor edge and vertex search loops in 2D grid point localization
matthew-mccall
committed
Reversed algorithm logic and implemented tolerances
matthew-mccall
committed
Refactor point search tolerances handling and rename Result fields
matthew-mccall
committed
Refactor GridPointSearch2D result assignment logic and update tolerances handling
matthew-mccall
committed
Refactor edge handling in GridPointSearch2D and extend test cases
matthew-mccall
committed
Ran clang format
matthew-mccall
committed
fix narrowing conversion
matthew-mccall
committed
Correctly initialize initial min and max for n dimensions

matthew-mccall
and
Copilot
committed
correct wording for 3D meshes

matthew-mccall
and
Copilot
committed
update TODO comment in omega_h_field.h
matthew-mccall
committed
Update OmegaHField2 to use GridPointSearch2D
matthew-mccall
committed
Apply minor formatting adjustments and line splits in point_search and omega_h files
matthew-mccall
committed
Remove unused `KOKKOS_FUNCTION` annotation and correct TODO comment in point_search files
matthew-mccall
committed
Replace `GridPointSearch` with `GridPointSearch2D` in `omega_h_field2` for 2D-specific compatibility improvements and clarity
matthew-mccall
committed
Refactor `distance_from_line` to use vector-based formulation and simplify call sites in `point_search.cpp`. Fix test expectation in `test_point_search.cpp`.
matthew-mccall
committed
Refactor `normal_intersects_segment` to use vector-based approach, simplify logic, and update call sites in `point_search.cpp`.
matthew-mccall
committed
Fix `PointSearchTolerances` initialization in `test_point_search.cpp` to use `Kokkos::deep_copy` for proper device-host synchronization.
matthew-mccall
committed

Commits on Feb 26, 2026

Apply minor formatting fixes and update variable types in `distance_from_line` and `normal_intersects_segment` implementations in `point_search.cpp`.
matthew-mccall
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Tolerances to 2D Search and begin 3D Search Implementation#214

Add Tolerances to 2D Search and begin 3D Search Implementation#214
matthew-mccall wants to merge 25 commits intoSCOREC:developfrom
matthew-mccall:2d-tolerance-search

Commits on Feb 19, 2026

Refactor GridPointSearch to support dimensional template specialization.

Switch `optional` to `unique_ptr`

Add 3D grid point search functionality and refactor 2D implementation

Replace custom barycentric_from_global with Omega_h implementation

Add bbox_verts_within_simplex function and virtual destructor

Refactor point search to support 3D grids.

Add REGION dimensionality to point search

Refactor edge and vertex search loops in 2D grid point localization

Reversed algorithm logic and implemented tolerances

Refactor point search tolerances handling and rename Result fields

Refactor GridPointSearch2D result assignment logic and update tolerances handling

Refactor edge handling in GridPointSearch2D and extend test cases

Ran clang format

fix narrowing conversion

Correctly initialize initial min and max for n dimensions

correct wording for 3D meshes

update TODO comment in omega_h_field.h

Update OmegaHField2 to use GridPointSearch2D

Apply minor formatting adjustments and line splits in point_search and omega_h files

Remove unused `KOKKOS_FUNCTION` annotation and correct TODO comment in point_search files

Replace `GridPointSearch` with `GridPointSearch2D` in `omega_h_field2` for 2D-specific compatibility improvements and clarity

Refactor `distance_from_line` to use vector-based formulation and simplify call sites in `point_search.cpp`. Fix test expectation in `test_point_search.cpp`.

Refactor `normal_intersects_segment` to use vector-based approach, simplify logic, and update call sites in `point_search.cpp`.

Fix `PointSearchTolerances` initialization in `test_point_search.cpp` to use `Kokkos::deep_copy` for proper device-host synchronization.

Commits on Feb 26, 2026

Apply minor formatting fixes and update variable types in `distance_from_line` and `normal_intersects_segment` implementations in `point_search.cpp`.