Split SCons.Util even more, discourage implicit imports#4830
Open
Repiteo wants to merge 1 commit intoSCons:masterfrom
Open
Split SCons.Util even more, discourage implicit imports#4830Repiteo wants to merge 1 commit intoSCons:masterfrom
SCons.Util even more, discourage implicit imports#4830Repiteo wants to merge 1 commit intoSCons:masterfrom
Conversation
Repiteo
commented
Feb 17, 2026
Comment on lines
-455
to
+461
| StringTypes=StringTypes, | ||
| SequenceTypes=SequenceTypes, | ||
| StringTypes=StringTypes, # type: ignore | ||
| SequenceTypes=SequenceTypes, # type: ignore |
Contributor
Author
There was a problem hiding this comment.
Trying to use SCons.Util.sctypes.* here causes circular imports. Could maybe be circumvented with local import syntax, but it's simpler to just use the legacy values and silence the warnings.
Collaborator
|
I don't have a problem with this in concept. Away from big screens for a while, so is kind of hard to review. The new Tests.py files are all moved content, right? (UtilsTests has such a big diff it's collapsing it and not showing, means that'll be hard to tell visually). |
Contributor
Author
|
It's all moved content, correct |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
SCons.Utilmore package-y with a couple of changes:SCons.Util's implicit imports. This keeps the functionality working as-is, but now intellisense and IDEs will discourage not using the correct package explicitly.UtilTests.py.Contributor Checklist:
CHANGES.txtandRELEASE.txt(and read theREADME.rst).