fix: replace 64 bare except clauses with except Exception#4832
Closed
haosenwang1018 wants to merge 1 commit intoSCons:masterfrom
Closed
fix: replace 64 bare except clauses with except Exception#4832haosenwang1018 wants to merge 1 commit intoSCons:masterfrom
haosenwang1018 wants to merge 1 commit intoSCons:masterfrom
Conversation
Contributor
|
Looks like you didn't try to run the test suite on your changes before committing them. Note that catching SystemExit, KeyboardInterrupt, and GeneratorExit is indeed sometimes the intention in the code which failed during testing. |
Author
|
CI failures require manual fix. Closing for now. |
Contributor
|
If you submit PRs generated by AI, please include that information in your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace bare
except:clauses withexcept Exception:for PEP 8 compliance. Bare except catches SystemExit, KeyboardInterrupt, and GeneratorExit which is rarely intended.