Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set device in agent_update #103

Merged
merged 11 commits into from
Aug 22, 2024
Merged

set device in agent_update #103

merged 11 commits into from
Aug 22, 2024

Conversation

SarahAlidoost
Copy link

@SarahAlidoost SarahAlidoost commented Aug 8, 2024 •
edited
Loading

closes #87

see #87 (comment)

@SarahAlidoost SarahAlidoost mentioned this pull request Aug 8, 2024
Closed
@SarahAlidoost
Copy link
Author

@vmgaribay can you please review this pull request by running your experiment on snellius and check if issue #87 has been fixed? Please do not merge this pull request because I asked @vanlankveldthijs also to review the changes.

@SarahAlidoost SarahAlidoost marked this pull request as ready for review August 8, 2024 15:17
vanlankveldthijs
vanlankveldthijs approved these changes Aug 15, 2024
View reviewed changes
Copy link

@vanlankveldthijs vanlankveldthijs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good.
All tests successful, no new tests needed.

Good job. Can be merged if the snellius experiment is successful too.

vmgaribay
vmgaribay approved these changes Aug 21, 2024
View reviewed changes
Copy link

@vmgaribay vmgaribay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device now defined for update functions, and as a bonus, appears to have been lint-rolled. Should be good to merge

@vmgaribay
Copy link

Ah, no! Missed a bit of lint.

@vmgaribay
Copy link

vmgaribay commented Aug 21, 2024 •
edited
Loading

I see, it is the size thing that needs to be replaced with n_samples.
I wonder if I can change it without ruining it...

nope

@vmgaribay
Copy link

Yep!

@SarahAlidoost
Copy link
Author

I see, it is the size thing that needs to be replaced with n_samples. I wonder if I can change it without ruining it...

nope

I guess you missed issue #111 😄

@SarahAlidoost SarahAlidoost merged commit e93c027 into development Aug 22, 2024
5 checks passed
@SarahAlidoost SarahAlidoost deleted the fix_87 branch August 22, 2024 07:29
@meiertgrootes meiertgrootes mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vanlankveldthijs vanlankveldthijs vanlankveldthijs approved these changes

@vmgaribay vmgaribay vmgaribay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SarahAlidoost @vmgaribay @vanlankveldthijs