Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #615 | Add Dataloader IDK-MRC-NLI #631

Merged
merged 1 commit into from
May 13, 2024

Conversation

muhammadravi251001
Copy link
Collaborator

@muhammadravi251001 muhammadravi251001 commented Apr 8, 2024

Title: Add Dataloader IDK-MRC-NLI

First line PR Message: Closes #615

Notes

  • For the _CITATION field, I will add it later.

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script seacrowd/sea_datasets/{my_dataset}/{my_dataset}.py (please use only lowercase and underscore for dataset folder naming, as mentioned in dataset issue) and its __init__.py within {my_dataset} folder.
  • Provide values for the _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _LOCAL, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py or python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py --subset_id {subset_name_without_source_or_seacrowd_suffix}.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

@muhammadravi251001 muhammadravi251001 changed the title finishing idk_mrc_nli dataloader Add Dataloader IDK-MRC-NLI Apr 8, 2024
@muhammadravi251001 muhammadravi251001 changed the title Add Dataloader IDK-MRC-NLI Closes #615 | Add Dataloader IDK-MRC-NLI Apr 8, 2024
Copy link
Collaborator

@SamuelCahyawijaya SamuelCahyawijaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muhammadravi251001 : The dataloader looks good. Perhaps you can update the _CITATION since it is already May 1st?

Btw, I notice that the number of sample in the homepage is slightly different to the one in the CSV file.

Copy link
Collaborator

@SamuelCahyawijaya SamuelCahyawijaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muhammadravi251001 : Thank you for the update! LGTM!

@muhammadravi251001
Copy link
Collaborator Author

@muhammadravi251001 : Thank you for the update! LGTM!

Thanks for the approval, Sir!

@holylovenia
Copy link
Contributor

A friendly reminder for @luckysusanto to review.

Copy link
Collaborator

@luckysusanto luckysusanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works well, but, I noticed that there are only two labels in the dataset:
0 and 2.

I checked the original homepage, and the owner did state that there are 3 labels:
Entailment (0), neutral (1), and contradiction (2).
However, the original dataset only contains two labels: either entailment or contradiction.

I think it would be better for us to turn "contradiction" into (1) [changed from (2)], and then put a comment/note on the file. I fear that currently, it might cause some confusion for users later on

cc: @holylovenia

@muhammadravi251001
Copy link
Collaborator Author

muhammadravi251001 commented May 11, 2024

The code works well, but, I noticed that there are only two labels in the dataset:
0 and 2.

I checked the original homepage, and the owner did state that there are 3 labels:
Entailment (0), neutral (1), and contradiction (2).
However, the original dataset only contains two labels: either entailment or contradiction.

I think it would be better for us to turn "contradiction" into (1) [changed from (2)], and then put a comment/note on the file. I fear that currently, it might cause some confusion for users later on

cc: @holylovenia

It was done on purpose, Lucky. I've already made the explanation/clarification on this comment for the same task of my NLI dataset: #633 (comment)

@luckysusanto
Copy link
Collaborator

I see, in that case, approved!

@muhammadravi251001
Copy link
Collaborator Author

I see, in that case, approved!

Alright, thanks for the approval, Lucky!

@holylovenia holylovenia merged commit 08f1226 into SEACrowd:master May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for IDK-MRC-NLI
4 participants