Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #614 | Add Dataloader LEXiTRON #646

Merged
merged 4 commits into from
May 20, 2024

Conversation

muhammadravi251001
Copy link
Collaborator

Title: Add Dataloader LEXiTRON

First line PR Message: Closes #614

Note: There are no citations available for this dataset.

Checkbox

  • Confirm that this PR is linked to the dataset issue.
  • Create the dataloader script seacrowd/sea_datasets/{my_dataset}/{my_dataset}.py (please use only lowercase and underscore for dataset folder naming, as mentioned in dataset issue) and its __init__.py within {my_dataset} folder.
  • Provide values for the _DATASETNAME, _DESCRIPTION, _HOMEPAGE, _LICENSE, _LOCAL, _URLs, _SUPPORTED_TASKS, _SOURCE_VERSION, and _SEACROWD_VERSION variables.
  • Implement _info(), _split_generators() and _generate_examples() in dataloader script.
  • Make sure that the BUILDER_CONFIGS class attribute is a list with at least one SEACrowdConfig for the source schema and one for a seacrowd schema.
  • Confirm dataloader script works with datasets.load_dataset function.
  • Confirm that your dataloader script passes the test suite run with python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py or python -m tests.test_seacrowd seacrowd/sea_datasets/<my_dataset>/<my_dataset>.py --subset_id {subset_name_without_source_or_seacrowd_suffix}.
  • If my dataset is local, I have provided an output of the unit-tests in the PR (please copy paste). This is OPTIONAL for public datasets, as we can test these without access to the data files.

@holylovenia holylovenia requested review from ljvmiranda921 and removed request for MJonibek May 13, 2024 08:46
Copy link
Collaborator

@ljvmiranda921 ljvmiranda921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran the data loader and it worked! Can you rerun make check_file for formatting again?

seacrowd/sea_datasets/lexitron/lexitron.py Outdated Show resolved Hide resolved
@muhammadravi251001
Copy link
Collaborator Author

Ran the data loader and it worked! Can you rerun make check_file for formatting again?

It's already done Sir on a185ae4 commit.

Copy link
Collaborator

@ljvmiranda921 ljvmiranda921 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes! LGTM

@muhammadravi251001
Copy link
Collaborator Author

Thanks for applying the changes! LGTM

Thanks for the approval, Sir!

Copy link
Collaborator

@dehanalkautsar dehanalkautsar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I also tried to run the dataloader and it ran pretty well. I think the code itself is quite clean. LGTM!

@muhammadravi251001
Copy link
Collaborator Author

Hi! I also tried to run the dataloader and it ran pretty well. I think the code itself is quite clean. LGTM!

Thanks for the approval, Sir!

@ljvmiranda921
Copy link
Collaborator

Merging in a few :)

@ljvmiranda921 ljvmiranda921 merged commit 61370c2 into SEACrowd:master May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create dataset loader for LEXiTRON
5 participants