Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: changing speed and rpm to floats #163

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

rui-rocha-42
Copy link

@rui-rocha-42 rui-rocha-42 commented Feb 7, 2025

Description

  • Changed speed and rpm to floats. The can message of 8 bytes now contain only the speed and rpm in each 4 bytes.
  • Changed instrument cluster to handle new message format
  • Created a speed simulator for seeing real time changes

Checklist

  • Code follows project style guidelines.
  • Tests added or updated.
  • Documentation updated (if applicable).
  • Tested in simulation/real-world environment (if applicable).

Testing

  • Tested locally

Related Issue

#85

Notes

N/A

@rui-rocha-42 rui-rocha-42 added the enhancement New feature or request label Feb 7, 2025
@rui-rocha-42 rui-rocha-42 self-assigned this Feb 7, 2025

This comment was marked as outdated.

@rui-rocha-42 rui-rocha-42 force-pushed the feature/speed-rpm-float branch from 8035c8e to d72d546 Compare February 7, 2025 11:14

This comment was marked as outdated.

@rui-rocha-42 rui-rocha-42 force-pushed the feature/speed-rpm-float branch from d72d546 to f78dff9 Compare February 7, 2025 11:32

This comment was marked as outdated.

@rui-rocha-42 rui-rocha-42 force-pushed the feature/speed-rpm-float branch from f78dff9 to 210eaa7 Compare February 7, 2025 11:49

This comment was marked as outdated.

@rui-rocha-42 rui-rocha-42 force-pushed the feature/speed-rpm-float branch from 210eaa7 to dcdc472 Compare February 7, 2025 15:29
Copy link

github-actions bot commented Feb 7, 2025

Coverage for impacted relevant source files:

File Old Coverage New Coverage Difference
com-middleware/src/main.cpp 0.00% 0.00% 0.00%
instrument-cluster/main.cpp 0.00% 0.00% 0.00%
instrument-cluster/mq/ZMQSubscriber.cpp 0.00% 0.00% 0.00%
instrument-cluster/src/DataManager.cpp 0.00% 0.00% 0.00%
instrument-cluster/src/DataManager.hpp 0.00% 0.00% 0.00%
mq/src/ZeroMQSocket.cpp 78.72% 79.55% 0.82%
platform/battery-sensor/main.cpp 0.00% 0.00% 0.00%
platform/temperature-sensor/main.cpp 0.00% 0.00% 0.00%

@rui-rocha-42 rui-rocha-42 force-pushed the feature/speed-rpm-float branch from dcdc472 to 6a05345 Compare February 12, 2025 16:18
@rui-rocha-42 rui-rocha-42 merged commit f750555 into main Feb 12, 2025
13 checks passed
@rui-rocha-42 rui-rocha-42 deleted the feature/speed-rpm-float branch February 12, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants