Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retro 1 #26

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/check_pr_description.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# yamllint disable rule:line-length
---
name: PR description
on: # yamllint disable-line rule:truthy
Expand All @@ -14,11 +13,11 @@
id: contains_issue
run: |
PR_BODY=$(curl -s https://api.github.com/repos/${{
github.repository }}/pulls/${{ github.event.pull_request.number }} | jq -r .body)

Check failure on line 16 in .github/workflows/check_pr_description.yml

View workflow job for this annotation

GitHub Actions / yamllint

16:81 [line-length] line too long (93 > 80 characters)
echo "$PR_BODY"
pattern="https://github\.com/([a-zA-Z0-9_-]+)/([a-zA-Z0-9_-]+)/issues/([0-9]+)"
if [[ ! "$PR_BODY" =~ $pattern ]]; then
echo "Error: PR description must include an issue link in the format 'Issue: # 123' or 'Issue: https://github.com/owner/repo/issues/123'." >&2

Check failure on line 20 in .github/workflows/check_pr_description.yml

View workflow job for this annotation

GitHub Actions / yamllint

20:81 [line-length] line too long (155 > 80 characters)
exit 1
else
echo "PR description contains a valid issue link."
Expand All @@ -26,4 +25,4 @@
- name: Fail PR if no issue link found
if: failure()
run: |-
echo "Please add an issue link in the format 'Issue: # 123' or 'Issue: https://github.com/owner/repo/issues/123' in the PR description."

Check failure on line 28 in .github/workflows/check_pr_description.yml

View workflow job for this annotation

GitHub Actions / yamllint

28:81 [line-length] line too long (146 > 80 characters)
2 changes: 1 addition & 1 deletion examples/cpp/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ cc_test(
name = "test",
srcs = ["test.cpp"],
deps = [
":lib",
"@googletest//:gtest",
"@googletest//:gtest_main",
":lib",
],
)
4 changes: 3 additions & 1 deletion examples/cpp/hello.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#include <string>

auto greet() -> std::string { return "Hello World!"; }
std::string greet( ){
return "Hello World!";
}

auto farewell() -> std::string { return "Bye World!"; }
2 changes: 1 addition & 1 deletion examples/cpp/hello.hpp
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#include <string>

auto greet() -> std::string;
std::string greet();
auto farewell() -> std::string;
Loading