-
Notifications
You must be signed in to change notification settings - Fork 6
[scfinder] Add clipping handling to PGA processing #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FMassin
commented
Nov 1, 2024
FMassin
commented
Nov 21, 2024
@@ -8,7 +8,7 @@ | |||
<configuration> | |||
<parameter name="saturationThreshold" type="double" default="80" unit="percent"> | |||
<description> | |||
Saturation threshold in percent of 2**31 of raw values (COUNTS). | |||
Saturation threshold in percent of 2**23 of raw values (COUNTS). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jenrandrews Saturation reference value is already fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents the use of clipped data in further processing and adds additional logging and select the appropriate envelope for PGA processing based on instrument gain units.
Ambiguituous processing of vertical and horizontal PGA remains.
Key Changes:
clipTimeout
window.Unit Test
The two new features can be tested with the unit test data as follows:
Instrument Gain Unit Check and Prevailing (M/S**2 by default):
HG [M/S**2] rules over HH [M/S]
temp_data/*/data_*
files.temp_data/*/data_*
files (e.g., 20 HG less in data_2).Discarding of clipped data:
Instrument clipped and skipped
Instrument clipped recently and skipped
temp_data/*/data_*
files.