Update Salesforce Dependency and Enhance benchmark object retrieval#5179
Merged
axelstudios merged 8 commits intodevelopfrom Mar 17, 2026
Merged
Update Salesforce Dependency and Enhance benchmark object retrieval#5179axelstudios merged 8 commits intodevelopfrom
axelstudios merged 8 commits intodevelopfrom
Conversation
Contributor
kflemin
commented
Mar 4, 2026
kflemin
commented
- Update seed-salesforce dependency to v0.2.0
- Fix/Enhance retrieval of benchmark object by a custom ID (name/value pair) - this was previously implemented but had a slight bug in the functionality.
kflemin
added
the
Enhancement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Salesforce integration dependency and adjusts the SEED→Salesforce sync flow to locate the target Benchmark record via a configured custom ID field/value before issuing the update.
Changes:
- Bump
seed-salesforcedependency to0.2.0. - Update
update_salesforce_propertyto fetch the Salesforce Benchmark by custom-id (fieldname + value) and then update by the returned recordId. - Add several runtime
print(...)statements for debugging (currently left in the implementation).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
seed/utils/salesforce.py |
Adds benchmark lookup by custom id prior to update; introduces multiple debug print statements and new lookup failure modes that need handling. |
requirements/base.txt |
Updates seed-salesforce pinned version to 0.2.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
axelstudios
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.