Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Models implementation #18

Merged
merged 19 commits into from
Mar 2, 2024
Merged

Models implementation #18

merged 19 commits into from
Mar 2, 2024

Conversation

RunoBoy
Copy link
Contributor

@RunoBoy RunoBoy commented Feb 27, 2024

  • Features an implementation of the EER in DJango
  • Skips the groups entity
  • Small addon to .gitignore to ignore the database file and the virtual environment

Fixes issue #2

edit after commit 140c726:
Also fixes issue #16 (User Implementation)

@RunoBoy RunoBoy added the enhancement New feature or request label Feb 27, 2024
@RunoBoy RunoBoy added this to the Milestone 1 milestone Feb 27, 2024
@RunoBoy
Copy link
Contributor Author

RunoBoy commented Feb 27, 2024

A first version of serializers (= for an api response) is also added but currently not important for the current issue

@robinpdev
Copy link
Contributor

Ik ga straks een scriptje toevoegen waarmee je lokaal kan linten, maar khet commando is denkik docker exec pigeonhole-backend flake8 pigeonhole/ testapi/ (...enzv met nog andere folders die moeten gelint worden). Het kan zijn dat je in .flake8 meer migration mappen moet negeren als je meer app folders aanmaakt

@axellorreyne
Copy link
Contributor

Ik ga straks een scriptje toevoegen waarmee je lokaal kan linten, maar khet commando is denkik docker exec pigeonhole-backend flake8 pigeonhole/ testapi/ (...enzv met nog andere folders die moeten gelint worden). Het kan zijn dat je in .flake8 meer migration mappen moet negeren als je meer app folders aanmaakt

Maybe we can use a Makefile?
Then we can complete such tasks by simply running make lint.

@robinpdev
Copy link
Contributor

Ik ga straks een scriptje toevoegen waarmee je lokaal kan linten, maar khet commando is denkik docker exec pigeonhole-backend flake8 pigeonhole/ testapi/ (...enzv met nog andere folders die moeten gelint worden). Het kan zijn dat je in .flake8 meer migration mappen moet negeren als je meer app folders aanmaakt

Maybe we can use a Makefile? Then we can complete such tasks by simply running make lint.

Done, you can merge it from the dev branch now

@axellorreyne axellorreyne marked this pull request as ready for review March 1, 2024 17:38
@axellorreyne axellorreyne self-requested a review March 1, 2024 17:38
@axellorreyne axellorreyne requested a review from PJDeSmijter March 1, 2024 17:38
Copy link
Contributor

@PJDeSmijter PJDeSmijter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, altho some fields like submission description or testfiles are missing, would be great if you'd add them later, altho it's better for this branch to be merged so API team can start.

@RunoBoy RunoBoy merged commit f042cc1 into develop Mar 2, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants