Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

secadm: remove duplicate policies #848

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

uudiin
Copy link
Contributor

@uudiin uudiin commented Dec 19, 2024

There are some duplicate policies in secadm, which are defined in userdom_security_admin_template() and remove them in secadm.

@pebenito
Copy link
Member

pebenito commented Jan 6, 2025

I'm seeing this diff from the GitHub actions:

Allow Rules (0 Added, 2 Removed, 0 Modified)
   Removed Allow Rules: 2
      - allow bootloader_t autofs_t:dir { getattr ioctl lock open read search };
      - allow systemd_logind_t autofs_t:filesystem getattr; [ systemd_logind_get_bootloader ]:True

Dontaudit Rules (0 Added, 1 Removed, 0 Modified)
   Removed Dontaudit Rules: 1
      - dontaudit useradd_t var_spool_t:dir { getattr open search };

But that may be due to other PRs merging. Please rebase so we can verify we don't lose any rules.

There are some duplicate policies in secadm, which are defined
in userdom_security_admin_template() and remove them in secadm.

Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
@uudiin
Copy link
Contributor Author

uudiin commented Jan 6, 2025

@pebenito rebase has been done. As you said, this was due to other PRs merging.

@pebenito pebenito merged commit aa1d9dd into SELinuxProject:main Jan 6, 2025
118 checks passed
@uudiin uudiin deleted the secadmfix branch January 7, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants