Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create updated Ubuntu ECP image/CI job #120

Merged
merged 7 commits into from
Jun 28, 2023

Conversation

willdunklin
Copy link
Contributor

Adds a new ECP test image based on the ecp ubuntu20.04 runner

@willdunklin
Copy link
Contributor Author

Just wanted to note that the CI approval is hanging since the fedora35-ecp-catalyst job was removed. I can add the job back into the PR but the Ubuntu image is meant to supplant the older fedora image.

@burlen
Copy link
Contributor

burlen commented May 12, 2023

20.04 is pretty out dated, since we are making the effort to update this why not use ubuntu 22.04 (already a year old). I've had to move to 22.04 in my development systems to get the latest ROCm release (needed for asynchrounous data transfer). Similarly I had to go to Fedora 37 to get the latest CUDA 12 release because of compiler bugs in 11. Also Fedroa 38 was released recently and official CUDA support expected to come in the next CUDA minor release.

@willdunklin
Copy link
Contributor Author

@burlen
The image is based on the E4S runner image, which is related to the environments the ecp sdk will be ran in. The target HPC systems will be stuck on 20.04 for quite some time, so for the sake of this integration test, it might be best to stick with this version.

@willdunklin willdunklin changed the base branch from master to develop May 16, 2023 19:23
@burlen
Copy link
Contributor

burlen commented May 18, 2023

Feel free to merge this once Ryan is set

@willdunklin
Copy link
Contributor Author

I've wrapped up the changes for this PR (@kwryankrattiger previously reviewed this with me, although another look would be appreciated).

One note is that I needed to use ADIOS2 2.8.3 for the tests to pass, see #133 for info about the failing tests. The Ubuntu image should have parity with the old Fedora one now.


# install
N_THREADS=$(grep -c '^processor' /proc/cpuinfo)
spack install -v --use-cache --no-check-signature -j ${N_THREADS}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for this we also want to add --only dependencies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, actually I think we want to remove the next line, considering this should also install an up to date lmod. Is the splitting between dependencies and the packages important for this script?

Copy link
Contributor

@kwryankrattiger kwryankrattiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay.

@kwryankrattiger kwryankrattiger merged commit 26ccb03 into SENSEI-insitu:develop Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants