-
-
Couldn't load subscription status.
- Fork 1.2k
ApplyEffect implementation #1688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
fe0e630 to
5b96a18
Compare
03fd671 to
61d409b
Compare
8449c6d to
51416c3
Compare
d79f834 to
26bac42
Compare
30c0ef0 to
35d4f37
Compare
35d4f37 to
63bc382
Compare
|
Hey @heinezen , what's the state of this PR? Is it ready-ish or faraway? Maybe you can add some details in here |
b1ac0c6 to
a4b8864
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 95 out of 96 changed files in this pull request and generated no comments.
Files not reviewed (1)
- libopenage/curve/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (1)
libopenage/curve/continuous.h:77
- The 'compress' parameter in set_insert is declared but not used; if compression is intended for insertions, consider incorporating this flag into the implementation or removing it to avoid confusion.
void Continuous<T>::set_insert(const time::time_t &t, const T &value, bool /* compress */) {
6023b34 to
2f0e318
Compare
635b0f5 to
fd5ea13
Compare
d0c151a to
a8df5d5
Compare
Implements a system to use the
ApplyEffectability of the nyan API.Resolves #671
nyan::Objecthandle asshared_ptrnyan#124ValueHolderto specificValuedirectly in nyan API nyan#125Other Features