Pathfinder history #1748
Open
Pathfinder history #1748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jere8184
force-pushed
the
pathfinder_history
branch
from
2a3d646 to
df2f0ab
Compare
jere8184
commented
Jan 26, 2025
libopenage/pathfinding/cost_field.h
Outdated
| /** | ||
| * Array curve recording cell cost history, | ||
| */ | ||
| curve::Array<cost_t, CHUNK_SIZE> cell_cost_history; |
There was a problem hiding this comment.
How should cell_cost_history be exposed? A simple getter that returns a constant ref to the curve?
There was a problem hiding this comment.
Yes that would be enough I think.
jere8184
force-pushed
the
pathfinder_history
branch
from
df2f0ab to
8d216b9
Compare
heinezen
requested changes
Apr 8, 2025
libopenage/pathfinding/cost_field.h
Outdated
| /** | ||
| * Array curve recording cell cost history, | ||
| */ | ||
| curve::Array<cost_t, CHUNK_SIZE> cell_cost_history; |
There was a problem hiding this comment.
Yes that would be enough I think.
heinezen
added
improvement
Co-authored-by: jere8184 <jeremiahmorgan.bham@outlook.com>
jere8184
force-pushed
the
pathfinder_history
branch
from
63c919d to
b390440
Compare
heinezen
requested changes
May 25, 2025
github-project-automation
bot
moved this from 👀 In review
to 🔖 TODO
in openage game simulation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1680