Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify documentation of datamodels and usage of plugins #977

Merged
merged 19 commits into from
Oct 28, 2024

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented Oct 23, 2024

Description

I keep having problems with creating my own plugins and datamodels, and there
are so many inconsistent examples around.

I try here to clarify some of the things and add a small section on how to make entities, that is easy to find.

Type of change

  • Bug fix & code cleanup
  • New feature
  • Documentation update
  • Test update

Checklist for the reviewer

This checklist should be used as a help for the reviewer.

  • Is the change limited to one issue?
  • Does this PR close the issue?
  • Is the code easy to read and understand?
  • Do all new feature have an accompanying new test?
  • Has the documentation been updated as necessary?

@francescalb francescalb linked an issue Oct 23, 2024 that may be closed by this pull request
@francescalb francescalb changed the title Adde description on how to set paths to plugins in the plugins documentation Add description on how to set paths to plugins in the plugins documentation Oct 23, 2024
@jesper-friis
Copy link
Collaborator

Ønsker du helt å slette avsnittet om datamodeller eller bare forbedre det?

Also removed many different ways of doing it
so that we rather show one and have people use that
@francescalb
Copy link
Collaborator Author

Ønsker du helt å slette avsnittet om datamodeller eller bare forbedre det?

No, I had forgotten to push the file. However, I think it smart to now have many different examples which are confusing and rather provide the preferred one (yaml, newer version).

@francescalb francescalb changed the title Add description on how to set paths to plugins in the plugins documentation Simplify documentation of datamodels and usage of plugins Oct 25, 2024
Comment on lines 56 to 65
dlite-validate
==============
The dlite-validate tool can be used to check if a specific representation (in a file) is a valid DLite datamodel

This can be run as follows
```bash
dlite-validate filename.yaml # or json
```

It will then return a list of errors if it is not a valid representation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be moved to doc/user_guide/tools.md. But it would be great with a note here saying that datamodels can be validated using the dlite_validate tool, with a reference to the correct section in doc/user_guide/tools.md.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you pushed the changes to doc/user_guide/tools.md?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, waiting for you answer on teams.

francescalb and others added 7 commits October 25, 2024 22:04
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@francescalb francescalb merged commit 33c841f into master Oct 28, 2024
14 checks passed
@francescalb francescalb deleted the flb/path_description_in_plugins_docs branch October 28, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants