Fix dlite.Instance.from_dict() to correctly parse ref-type properties
#983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francescalb
reviewed
Oct 25, 2024
francescalb
reviewed
Oct 25, 2024
| Top = dlite.get_instance("http://onto-ns.com/meta/0.1/Top") | ||
| Middle = dlite.get_instance("http://onto-ns.com/meta/0.1/Middle") | ||
| Middle = dlite.get_instance("http://onto-ns.com/meta/0.2/Middle") |
There was a problem hiding this comment.
I think we should still test json as well
There was a problem hiding this comment.
We are still testing JSON, since all the other datamodels are read from input/test_ref_type.json.
francescalb
reviewed
Oct 25, 2024
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
Sorry, unsure what you mean here? The YAML plugin is written in Python, but it is still be used from C via the embedded interpreter. |
OK, thank you for the clarification. |
francescalb
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should make it possible to correctly parse YAML files with ref-type properties.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.