Validate multiple instances #986
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesper-friis
requested review from
francescalb
and removed request for
francescalb
jesper-friis
commented
Oct 29, 2024
jesper-friis
commented
Oct 29, 2024
… into validate-multiple-instances
francescalb
reviewed
Nov 4, 2024
francescalb
reviewed
Nov 4, 2024
bindings/python/tests/test_jstore.py
Outdated
Comment on lines
38
to
55
| d1 = { | ||
| "uuid": "d6a1c1db-44b6-5b87-b815-83f1127395b6", | ||
| "meta": "http://onto-ns.com/meta/ex/0.2/Test", | ||
| "dimensions": {"n": 3}, | ||
| "properties": { | ||
| "a": "hello", | ||
| "b": [1.1, 2.2, 3.3], | ||
| }, | ||
| } | ||
| d2 = { | ||
| "uuid": "d6a1c1db-44b6-5b87-b815-83f1127395b6", | ||
| "meta": "http://onto-ns.com/meta/ex/0.2/Test", | ||
| "dimensions": {"n": 3}, | ||
| "properties": { | ||
| "a": "hello", | ||
| "b": [1.1, 2.2, 3.3], | ||
| }, | ||
| } |
There was a problem hiding this comment.
What is the difference between these two?
There was a problem hiding this comment.
Good observation. You are right, for data instances there are no difference between the old and soft7 representations. I added a comment about this to the test
Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
… into validate-multiple-instances
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update
dlite-validateto validate sources with multiple instances, without having to provide the--idoption.This PR build on top of PR #985.
Update: Added new Python interface to the jstore implemented in C. Right now this increases the code base, but this change makes it possible to e.g. reduce
utils.instance_from_dict()andInstance.asdict()to a few lines of code. An added benefit would be consistency with JSON parsing (since the json parser in C is used under the hood).Suggests to take the code removal/replacement in a separate PR to have little more control over changes.
Type of change
Checklist for the reviewer
This checklist should be used as a help for the reviewer.